Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orchid 13 support #8

Open
cryptodev4 opened this issue Aug 16, 2022 · 10 comments
Open

Orchid 13 support #8

cryptodev4 opened this issue Aug 16, 2022 · 10 comments

Comments

@cryptodev4
Copy link

Expected Behavior

Hi I want to install Orchid-Tables on Orchid 13

Actual Behavior

I was trying to add Orchid-Tables by Lintaba on Orchid latest version (13) but I have a dependency error, does Orchid-Tables will support Orchid 13 version?

Steps to Reproduce the Problem

  1. Create a project with Laravel 9
  2. Install Orchid 13
  3. Try to install Orchid-Tables 1.1.1

Screenshots (if applicable)

image

Specifications

  • ORCHID Platform Version: 13
  • Laravel Version: 9
  • PHP Version: 8.1
  • Database Version: MariaDB 10.2

Other Notes

@Alessandro-Avallone-Developer

Same problem

@lintaba
Copy link
Owner

lintaba commented Aug 18, 2022

there were some breaking changes with orchid 13, and I haven't found the time yet to resolve those.
Its mainly about how resources and assets are handled. Feel free to help out and send a PR :)

@cryptodev4
Copy link
Author

Hi @lintaba, I was working in a workaround to make Orchid Tables work on Orchid 13, but I need permissions from you to create the branch with the changes and the PR to master to be reviewed.

@cryptodev4
Copy link
Author

I've created this fork just for test purposes and it works very well with Orchid 13 cryptodev4-orchid-tables maybe I don't deep dive into more details about functionality but the package finally can be installed.

@cryptodev4
Copy link
Author

Just to add more support I've been testing by adding a checkbox in the users list and this is the result.

Here I show the modal example with the checkbox selected

Then I send the modal and you can see that the 'checkbox' param arrives to the request

Then I show you how I configured the TDChecklist field

And finally show the composer.json

@lintaba
Copy link
Owner

lintaba commented Aug 19, 2022

you shouldn't need permission to fork, or to create a PR.

Currently I havent had the time to review if there were any breaking change related to the two packages (however as I see the removal of jQuery may cause some troubles, for example.)

@cryptodev4
Copy link
Author

Nice, I've already made the PR for the project, the only thing that I forget is to add the version release for the package, I think that you (@lintaba) fix that right? hehe

@cryptodev4
Copy link
Author

I realized that o made the commit with another account, I will change that

@cryptodev4
Copy link
Author

Another thing that I forget to said you (@lintaba ), is that jQuery can be added again via platform file, so I specify that detail on the readme file of lintaba/orchid-tables, and I think that jQuery version that suggest Orchid Platform could be fine to work without issues.

@lintaba
Copy link
Owner

lintaba commented Aug 19, 2022

@cryptodev4 jQuery was just a quick example, from a list of breaking changes. If/when i'll have time to update the lib i'll do so. If you can show that your changes are actually working (by working I mean all of the functionality of the lib are the same with the new version as it was with the old, it can be installed to a fresh instance, and also can be used to update from the old version), then I can apply the PR.

Meanwhile, feel free fork it and use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants