-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orchid 13 support #8
Comments
Same problem |
there were some breaking changes with orchid 13, and I haven't found the time yet to resolve those. |
Hi @lintaba, I was working in a workaround to make Orchid Tables work on Orchid 13, but I need permissions from you to create the branch with the changes and the PR to master to be reviewed. |
I've created this fork just for test purposes and it works very well with Orchid 13 cryptodev4-orchid-tables maybe I don't deep dive into more details about functionality but the package finally can be installed. |
you shouldn't need permission to fork, or to create a PR. Currently I havent had the time to review if there were any breaking change related to the two packages (however as I see the removal of jQuery may cause some troubles, for example.) |
Nice, I've already made the PR for the project, the only thing that I forget is to add the version release for the package, I think that you (@lintaba) fix that right? hehe |
I realized that o made the commit with another account, I will change that |
Another thing that I forget to said you (@lintaba ), is that jQuery can be added again via platform file, so I specify that detail on the readme file of lintaba/orchid-tables, and I think that jQuery version that suggest Orchid Platform could be fine to work without issues. |
@cryptodev4 jQuery was just a quick example, from a list of breaking changes. If/when i'll have time to update the lib i'll do so. If you can show that your changes are actually working (by working I mean all of the functionality of the lib are the same with the new version as it was with the old, it can be installed to a fresh instance, and also can be used to update from the old version), then I can apply the PR. Meanwhile, feel free fork it and use that. |
Expected Behavior
Hi I want to install Orchid-Tables on Orchid 13
Actual Behavior
I was trying to add Orchid-Tables by Lintaba on Orchid latest version (13) but I have a dependency error, does Orchid-Tables will support Orchid 13 version?
Steps to Reproduce the Problem
Screenshots (if applicable)
Specifications
Other Notes
The text was updated successfully, but these errors were encountered: