Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship AppImage of plugin that includes the dependencies #21

Open
TheAssassin opened this issue Apr 29, 2021 · 2 comments
Open

Ship AppImage of plugin that includes the dependencies #21

TheAssassin opened this issue Apr 29, 2021 · 2 comments

Comments

@TheAssassin
Copy link
Member

The gtk plugin has some dependencies which we should bundle, most notably patchelf and pkgconf. This way, we don't need to have users install random versions of the tools (mostly important for patchelf).

For patchelf, an alternative solution would be to have linuxdeploy set an environment variable to its own patchelf binary that the plugin reads and uses if available.

@TheAssassin TheAssassin mentioned this issue Feb 20, 2022
@TheTumultuousUnicornOfDarkness
Copy link
Collaborator

For pkgconf, I am not sure if bundling this tool is a great idea. If we bundle pkgconf with this plugin inside an AppImage, I am afraid that we may face the same issue as described here.
IMHO, pkgconf must be present on the system, as some .pc reside on host's filesystem.

@TheAssassin
Copy link
Member Author

TheAssassin commented Feb 21, 2022

The tool pkgconf will read the system .pc files anyway, though. I can't imagine that there's a lot of change to the way the tool works, honestly.

pkgconf is a developer tool, yes, but the dependency is also there in build environments etc. I think it's way more common than patchelf, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants