Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support authentication methods other than username/password #28

Open
rursprung opened this issue May 15, 2024 · 2 comments
Open

support authentication methods other than username/password #28

rursprung opened this issue May 15, 2024 · 2 comments

Comments

@rursprung
Copy link
Collaborator

the first version (#25) only introduces username/password authentication (easiest to implement & test), however opensearch offers various other authentication options (see the documentation) and we should support all of them eventually.

this issue should be used to define how this should be implemented and either do it directly for all of them (unlikely) or raise follow-up issues for the different authentication options to be implemented later on (with a clear way forward for them).

@reta
Copy link
Collaborator

reta commented May 24, 2024

At the moment, we provide HttpClientConfigCallback / HttpAsyncClientBuilder to allow configuring any aspect of the underlying client(s), including other authentication methods if supported. My concern regarding baking everything into the client itself is that it may not be practical - there are tons of different LDAP / SAML / OpenID / OAuth / JWT / ... libraries there, we cannot support all nor force to use one.

@rursprung
Copy link
Collaborator Author

e.g. for JWT support we need to be able to register an HttpRequestInterceptor here:

@filipelautert: what would be the canonical way to attach random things at runtime here? the liquibase API seems to be largely based on string-based configuration and not using injection, i.e. i can't just use the spring-way of injecting things, defining defaults in their absence, etc.

@rursprung rursprung added this to the v0.0.1 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants