Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database#getLineComment mustn't throw an exception #49

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

rursprung
Copy link
Collaborator

this was a last-minute change before merging PR #25 and we didn't spot this: all tests are failing due to this as this is being called by the constructor of ChangeLogParameters.

instead of returning something artifical (like //) which doesn't apply here we'll just return an empty string. this is needed until liquibase adds first-class support for NoSQL DBs and removes any SQL-specific features (requires liquibase/liquibase#4236).

this was a last-minute change before merging PR #25 and we didn't spot
this: all tests are failing due to this as this is being called by the
constructor of `ChangeLogParameters`.

instead of returning something artifical (like `//`) which doesn't apply
here we'll just return an empty string. this is needed until liquibase
adds first-class support for NoSQL DBs and removes any SQL-specific
features (requires liquibase/liquibase#4236).
@rursprung
Copy link
Collaborator Author

note: the integration tests were not executed, thus we didn't spot this. reported this in #48

Copy link

sonarcloud bot commented Sep 19, 2024

@rursprung rursprung merged commit e4ba691 into master Sep 19, 2024
13 checks passed
@rursprung rursprung deleted the fix-tests branch September 19, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants