Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Expires field #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Expires field #72

wants to merge 2 commits into from

Conversation

joker314
Copy link
Collaborator

@joker314 joker314 commented Sep 9, 2021

When ready, will resolve #68

@lirantal
Copy link
Owner

thanks!

@lirantal lirantal marked this pull request as ready for review September 10, 2021 05:23
@joker314
Copy link
Collaborator Author

I think I need to add some tests first because I haven't ran the code at all, but to be honest this looks correct 🤞

@lirantal
Copy link
Owner

lirantal commented Sep 14, 2021

Sounds good to me, however looks like CI is funky and this would also be a good time to convert from CircleCI to a GitHub Actions workflow.

@lirantal lirantal closed this Sep 18, 2021
@lirantal lirantal reopened this Sep 18, 2021
@lirantal
Copy link
Owner

lirantal commented Sep 18, 2021

@joker314 I updated to GitHub Actions. Can you check the build failures?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New field: "Expires"
2 participants