This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Improve build: use newer JRuby, enable build on docker and add GitLab CI support #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brodock
force-pushed
the
improve-build
branch
2 times, most recently
from
db5c709
to
eba3886
Compare
|
Thanks for the PR! The JRuby bump is a no-brainer, so I'd definitely like to pull that in. I don't think maintaining anything GitLab-specific makes sense in the main repo since it is not hosted there. For the Redis configuration, I'd rather expose explicitly configuration attributes than use environment variables. Something like |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request, updates JRuby version to a more recent one that will actually build and pass the specs.
It also provides an alternative to redefine Redis host and port for use during
testexecution phase.I've tried many alternatives to make this possible, but neither worked, this was the closest I got.
It also adds support for building with GitLab CI (you can see it building here: https://gitlab.com/brodock/lita/pipelines/3767259)
To use GitLab CI, you have to host the repository there (this can be done by mirroring it easily using the import tool).
This will fix #184