This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
Cleanup proto visibility #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The module `protocol` itself is private at crate level - Protocol, Response and the Request alias already are only `pub(crate)` at the crate level - There are two `From` implementations involving `Request`; without the explicit `Request` typename those should have been inaccessible from other crates - Request and Response are used in `pub` Protocol parts, but Protocol itself wasn't accessible from other crates, so this should matter - Can't see anything else that would have exposed the types so far -> shouldn't need a version bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As preparation for #170 (and I probably need to make more PRs before #170 is ready, and I'd like to base those on this to avoid merge conflicts).
See commit message why this shouldn't be an API break.