Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

Cleanup proto visibility #193

Merged
merged 2 commits into from
Nov 10, 2021

Commits on Oct 30, 2021

  1. Configuration menu
    Copy the full SHA
    cb7454b View commit details
    Browse the repository at this point in the history
  2. Mark protocol types pub(crate) throughout the crate

    - The module `protocol` itself is private at crate level
    - Protocol, Response and the Request alias already are only
      `pub(crate)` at the crate level
    - There are two `From` implementations involving `Request`; without the
      explicit `Request` typename those should have been inaccessible from
      other crates
    - Request and Response are used in `pub` Protocol parts, but Protocol
      itself wasn't accessible from other crates, so this should matter
    - Can't see anything else that would have exposed the types so far
    
    -> shouldn't need a version bump
    stbuehler committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    65cf17b View commit details
    Browse the repository at this point in the history