Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned/focused screen share track cannot be unpinned/unfocused #500

Closed
richthegxd opened this issue May 27, 2023 · 5 comments
Closed

Pinned/focused screen share track cannot be unpinned/unfocused #500

richthegxd opened this issue May 27, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@richthegxd
Copy link
Contributor

richthegxd commented May 27, 2023

Select which package(s) are affected

@livekit/components-react

Describe the bug

Hello everyone, I have encountered a bug in my and your application. The demo window or the user's camera does not decrease by clicking on the button.

I fixed this bug in my application by removing the focusTrack?.publication?.trackSid property from the useEffect dependencies in VideoConference.tsx.

I also ran into another problem, when focusing on another window, an error appears in the console and the focus window does not work as it should.

I attach a video with these bugs:
https://www.awesomescreenshot.com/video/17791574?key=becb61b26ece2ccc3dabc3dfec1e87a6

Reproduction

https://www.awesomescreenshot.com/video/17791574?key=becb61b26ece2ccc3dabc3dfec1e87a6

Logs

No response

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (2) x64 AMD Ryzen 5 5600X 6-Core Processor
    Memory: 2.67 GB / 4.81 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.19.0 - ~/.nvm/versions/node/v16.19.0/bin/node
    npm: 8.19.3 - ~/.nvm/versions/node/v16.19.0/bin/npm
  npmPackages:
    livekit-client: 1.9.7 => 1.9.7
    @livekit/components-react: 1.0.3 => 1.0.3
    @livekit/components-styles: 1.0.0 => 1.0.0

Severity

annoyance

Additional Information

No response

@lukasIO
Copy link
Contributor

lukasIO commented May 30, 2023

the video you attached doesn't seem to work, I get a invalid share key error when clicking the link!

@richthegxd
Copy link
Contributor Author

richthegxd commented Jun 1, 2023

@lukasIO sorry, my bad, a I have attached a new video

@lukasIO
Copy link
Contributor

lukasIO commented Jun 5, 2023

thanks! cc @Ocupe

@Ocupe
Copy link
Contributor

Ocupe commented Jun 8, 2023

#519 should fix the problem described here, where the track in focus could not be unfocused.
The Error while running updatePages() in the console does not seem to be related to the bug described in this issue.

@Ocupe Ocupe added the bug Something isn't working label Jun 13, 2023
@Ocupe Ocupe changed the title Error while running updatePages() Pinned/focused screen share track cannot be unpinned/unfocused Jun 13, 2023
@Ocupe
Copy link
Contributor

Ocupe commented Jun 13, 2023

Close this and open a new issue for the Error while running updatePages() bug. #524

@Ocupe Ocupe closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants