-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logarithmic binning of multiband track volumes #940
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3445ed9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
@@ -154,3 +153,51 @@ export function useMultibandTrackVolume( | |||
|
|||
return frequencyBands; | |||
} | |||
|
|||
function calculateLogBinEdges(minFreq: number, maxFreq: number, numBins: number): number[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth looking at Bark Scale also (https://en.wikipedia.org/wiki/Bark_scale) as it maps psychoacoustics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, nice! might be even better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mel Scale - https://en.wikipedia.org/wiki/Mel_scale may be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One is pitch and the other is loudness scale.
@lukasIO I guess this is just for nicer looking visuals, right? Do you maybe have a video showing the differences to the current implementation? |
for audio visualisation tasks it's more appropriate to use logarithmic binning of the linear frequency values in order to have a visual representation of frequency bands that more closely reflects human hearing.