Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: check output, if output is nil then ignore. #62

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jinleileiking
Copy link

@jinleileiking jinleileiking commented Feb 21, 2023

This will cause panic later.

err := bin.Add(output.bin.Element)

@biglittlebigben
Copy link
Contributor

You are right that we should handle this returned error. I'm however not sure whether we should fail the whole ingress instead of skipping the filling output. In which case did you see the NewVideoOutput failing?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants