Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial documentation of RoomConfiguration parameters #775

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

biglittlebigben
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 981aafa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@rektdeckard
Copy link
Contributor

rektdeckard commented Jul 31, 2024

This looks great! I took a pass at generating the TS bindings for this, and unfortunately, there is an open issue in ts-proto from 7 months ago that breaks compilation with the option needed to emit the FieldOptions. I was able to get it working with a temporary hack and eventually produced the annotated bindings:

image

Have not done deep testing to make sure this doesn't break things elsewhere, but it's possible the fix in ts-proto is as simple as that. I'll look into making a PR over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants