Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace protoyaml with fully opensource analog #863

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

T3RR7
Copy link

@T3RR7 T3RR7 commented Oct 18, 2024

This PR proposes replacement for buflint's protoyaml library as it's impossible to use LiveKit in some regions due the buflint policy.
The solution I found originally belongs to this guy.
All tests had passed.

UPD:
There's useful side effect - getting rid of buflint's protoyaml dependencies

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 5fd919c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@CLAassistant
Copy link

CLAassistant commented Oct 18, 2024

CLA assistant check
All committers have signed the CLA.

@T3RR7
Copy link
Author

T3RR7 commented Oct 18, 2024

Note: I noticed that some test failed. This is not related to this PR, all tests had passed locally on my PC with the same command used in CI. Also I checked out the test that failed and quickly run it with debugger, marshaller hasn't even been called.

@davidzhao
Copy link
Member

Could you elaborate what about buflint's policy that makes it impossible to use?

don't worry about the failing test, one of the test can be a bit flakey :(

@T3RR7
Copy link
Author

T3RR7 commented Oct 19, 2024

Could you elaborate what about buflint's policy that makes it impossible to use?

Of course. It's impossible to use buflint in Russia and Belorussia.

I'm sure that the professional community should stay out of any political conflicts, but the buflint doesn't think so, saying "No Russian and Belorussian people, you are bad! I forbid to lint your go code!"

It's impossible to access their solutions located in their infrastructure without VPN or GOPROXY. Therefore, it's impossible to use any LiveKit open source tools and libraries due to how go dependencies work.

@T3RR7
Copy link
Author

T3RR7 commented Oct 21, 2024

@davidzhao ping :)
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants