-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace protoyaml with fully opensource analog #863
base: main
Are you sure you want to change the base?
Conversation
|
Note: I noticed that some test failed. This is not related to this PR, all tests had passed locally on my PC with the same command used in CI. Also I checked out the test that failed and quickly run it with debugger, marshaller hasn't even been called. |
Could you elaborate what about buflint's policy that makes it impossible to use? don't worry about the failing test, one of the test can be a bit flakey :( |
Of course. It's impossible to use buflint in Russia and Belorussia. I'm sure that the professional community should stay out of any political conflicts, but the buflint doesn't think so, saying "No Russian and Belorussian people, you are bad! I forbid to lint your go code!" It's impossible to access their solutions located in their infrastructure without VPN or GOPROXY. Therefore, it's impossible to use any LiveKit open source tools and libraries due to how go dependencies work. |
@davidzhao ping :) |
This PR proposes replacement for buflint's
protoyaml
library as it's impossible to useLiveKit
in some regions due the buflint policy.The solution I found originally belongs to this guy.
All tests had passed.
UPD:
There's useful side effect - getting rid of buflint's
protoyaml
dependencies