-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to upstream sipgo parser #219
Conversation
7d44e99
to
51b8747
Compare
pkg/sip/protocol_test.go
Outdated
@@ -3,7 +3,7 @@ package sip | |||
import ( | |||
"testing" | |||
|
|||
"github.com/emiago/sipgo/sip" | |||
"github.com/livekit/sipgo/sip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just cosmetics, but we usually put livekit and 3rd party imports in different sections.
pkg/sip/client.go
Outdated
"github.com/frostbyte73/core" | ||
"github.com/livekit/sipgo" | ||
"github.com/livekit/sipgo/sip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetics, but we usually put livekit module imports in a different section than 3rd party.
pkg/sip/inbound.go
Outdated
"github.com/frostbyte73/core" | ||
"github.com/icholy/digest" | ||
"github.com/livekit/sipgo/sip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same cosmetics remark as above.
"github.com/livekit/psrpc" | ||
"github.com/livekit/sipgo/sip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same cosmetics remark as above. (I know there is already an import wrongly placed here 😊 )
pkg/sip/server.go
Outdated
"github.com/frostbyte73/core" | ||
"github.com/icholy/digest" | ||
"github.com/livekit/sipgo" | ||
"github.com/livekit/sipgo/sip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same cosmetics remark as above.
pkg/sip/service.go
Outdated
@@ -23,7 +23,7 @@ import ( | |||
"sync/atomic" | |||
"time" | |||
|
|||
"github.com/emiago/sipgo" | |||
"github.com/livekit/sipgo" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same cosmetics remark as above.
pkg/sip/service_test.go
Outdated
"github.com/emiago/sipgo" | ||
"github.com/emiago/sipgo/sip" | ||
"github.com/livekit/sipgo" | ||
"github.com/livekit/sipgo/sip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same cosmetics remark as above.
"github.com/frostbyte73/core" | ||
"github.com/icholy/digest" | ||
"github.com/livekit/sipgo" | ||
"github.com/livekit/sipgo/sip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same cosmetics remark as above.
test/integration/sip_test.go
Outdated
@@ -11,7 +11,7 @@ import ( | |||
"testing" | |||
"time" | |||
|
|||
sipgo "github.com/emiago/sipgo/sip" | |||
sipgo "github.com/livekit/sipgo/sip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same cosmetics remark as above.
51b8747
to
a5d37dd
Compare
a5d37dd
to
89f7648
Compare
No description provided.