Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to upstream sipgo parser #219

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Switch to upstream sipgo parser #219

merged 1 commit into from
Nov 15, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Nov 7, 2024

No description provided.

@dennwc dennwc self-assigned this Nov 7, 2024
@dennwc dennwc requested a review from a team as a code owner November 7, 2024 17:42
@@ -3,7 +3,7 @@ package sip
import (
"testing"

"github.com/emiago/sipgo/sip"
"github.com/livekit/sipgo/sip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cosmetics, but we usually put livekit and 3rd party imports in different sections.

"github.com/frostbyte73/core"
"github.com/livekit/sipgo"
"github.com/livekit/sipgo/sip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetics, but we usually put livekit module imports in a different section than 3rd party.

"github.com/frostbyte73/core"
"github.com/icholy/digest"
"github.com/livekit/sipgo/sip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same cosmetics remark as above.

"github.com/livekit/psrpc"
"github.com/livekit/sipgo/sip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same cosmetics remark as above. (I know there is already an import wrongly placed here 😊 )

"github.com/frostbyte73/core"
"github.com/icholy/digest"
"github.com/livekit/sipgo"
"github.com/livekit/sipgo/sip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same cosmetics remark as above.

@@ -23,7 +23,7 @@ import (
"sync/atomic"
"time"

"github.com/emiago/sipgo"
"github.com/livekit/sipgo"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same cosmetics remark as above.

"github.com/emiago/sipgo"
"github.com/emiago/sipgo/sip"
"github.com/livekit/sipgo"
"github.com/livekit/sipgo/sip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same cosmetics remark as above.

"github.com/frostbyte73/core"
"github.com/icholy/digest"
"github.com/livekit/sipgo"
"github.com/livekit/sipgo/sip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same cosmetics remark as above.

@@ -11,7 +11,7 @@ import (
"testing"
"time"

sipgo "github.com/emiago/sipgo/sip"
sipgo "github.com/livekit/sipgo/sip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same cosmetics remark as above.

@dennwc dennwc merged commit 5a05221 into main Nov 15, 2024
3 checks passed
@dennwc dennwc deleted the sipgo-upstream branch November 15, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants