[hexagon] Require "asserts" build for widen-not-load test #117414
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue was introduced in #116330 |
|
@llvm/pr-subscribers-backend-hexagon Author: Brian Cain (androm3da) ChangesThis test fails on the Full diff: https://github.com/llvm/llvm-project/pull/117414.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/Hexagon/widen-not-load.ll b/llvm/test/CodeGen/Hexagon/widen-not-load.ll
index 6206a0a5367e49..0ecdd8a3b78351 100644
--- a/llvm/test/CodeGen/Hexagon/widen-not-load.ll
+++ b/llvm/test/CodeGen/Hexagon/widen-not-load.ll
@@ -1,6 +1,8 @@
; Test that double word post increment load is not generated.
-; RUN: llc -march=hexagon -O2 -debug-only=hexagon-load-store-widening %s -o 2>&1 - | FileCheck %s
+; REQUIRES: asserts
+; RUN: llc -march=hexagon -O2 -debug-only=hexagon-load-store-widening \
+; RUN %s -o 2>&1 - | FileCheck %s
; Loads with positive invalid postinc is not widened
define ptr @test1() {
|
yandalur
reviewed
Nov 23, 2024
| ; RUN: llc -march=hexagon -O2 -debug-only=hexagon-load-store-widening %s -o 2>&1 - | FileCheck %s | ||
| ; REQUIRES: asserts | ||
| ; RUN: llc -march=hexagon -O2 -debug-only=hexagon-load-store-widening \ | ||
| ; RUN %s -o 2>&1 - | FileCheck %s |
There was a problem hiding this comment.
The second RUN line is missing a colon
There was a problem hiding this comment.
Fixed, thanks for catching it.
This test fails on the `clang-x64-windows-msvc` builder:
.---command stderr------------
| C:\b\slave\clang-x64-windows-msvc\llvm-project\llvm\test\CodeGen\Hexagon\widen-not-load.ll:7:16: error: CHECK-LABEL: expected string not found in input
| ; CHECK-LABEL: test1
| ^
| <stdin>:1:1: note: scanning from here
| llc.exe: Unknown command line argument '-debug-only=hexagon-load-store-widening'. Try: 'c:\b\slave\clang-x64-windows-msvc\build\stage1\bin\llc.exe --help'
| ^
| <stdin>:1:35: note: possible intended match here
| llc.exe: Unknown command line argument '-debug-only=hexagon-load-store-widening'. Try: 'c:\b\slave\clang-x64-windows-msvc\build\stage1\bin\llc.exe --help'
| ^
androm3da
force-pushed
the
bcain/widen_not_ld
branch
from
b47d94e
to
0a2b0f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails on the
clang-x64-windows-msvcbuilder: