Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch] fix cross_entropy_loss decomposition #3839

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yyp0
Copy link
Contributor

@yyp0 yyp0 commented Oct 31, 2024

No description provided.

Comment on lines +8934 to +8942

Type secondType;
if (reductionInt == 0) {
secondType = target.getType();
} else {
auto targetType = dyn_cast<BaseTensorType>(target.getType());
secondType = targetType.getWithSizesAndDtype({}, targetType.getDtype());
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Type secondType;
if (reductionInt == 0) {
secondType = target.getType();
} else {
auto targetType = dyn_cast<BaseTensorType>(target.getType());
secondType = targetType.getWithSizesAndDtype({}, targetType.getDtype());
}
Type secondType = target.getType();
if (reductionInt != 0) {
auto targetType = dyn_cast<BaseTensorType>(target.getType());
secondType = targetType.getWithSizesAndDtype({}, targetType.getDtype());
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants