Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_validate_parameters: small inconsistence for n_epochs #633

Closed
jondo opened this issue Mar 30, 2021 · 1 comment
Closed

_validate_parameters: small inconsistence for n_epochs #633

jondo opened this issue Mar 30, 2021 · 1 comment

Comments

@jondo
Copy link
Contributor

jondo commented Mar 30, 2021

See

umap/umap/umap_.py

Line 1705 in f86c922

self.n_epochs <= 10 or not isinstance(self.n_epochs, int)
:

The value n_epochs=10 gives the error n_epochs must be a positive integer of at least 10.

Either the error should only start at n_epochs=9, or the error message needs to say at least 11.
@jondo
Copy link
Contributor Author

jondo commented Mar 31, 2021

This was closed by #634.

@jondo jondo closed this as completed Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jondo