Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation on /settleorder #470

Closed
grunch opened this issue Jan 25, 2024 · 4 comments
Closed

Add validation on /settleorder #470

grunch opened this issue Jan 25, 2024 · 4 comments
Assignees
@AndreaDiazCorreia
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed 🪙 Reward in Sats ⚡

Comments

@grunch
Copy link
Member

grunch commented Jan 25, 2024

The /settleorder command should not be able to be executed if the status is already PAID_HOLD_INVOICE
@grunch grunch added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 25, 2024
@Catrya Catrya moved this to 👨‍💻 Looking for dev in Developer Rewards ⚡👩‍💻 Aug 10, 2024
@AndreaDiazCorreia
Copy link
Contributor

Hi, can I make this issue?

@Catrya Catrya moved this from 👨‍💻 Looking for dev to 📝 In Progress in Developer Rewards ⚡👩‍💻 Aug 14, 2024
@Catrya
Copy link
Member

Catrya commented Aug 14, 2024

Hi @AndreaDiazCorreia I already assigned it to you

@AndreaDiazCorreia
Copy link
Contributor

Hi, I made this pull request #567

@Catrya Catrya moved this from 📝 In Progress to ✅ Done in Developer Rewards ⚡👩‍💻 Aug 16, 2024
grunch pushed a commit that referenced this issue Aug 16, 2024
@AndreaDiazCorreia
Issue #470 Add validation on /settleorder (#567)
5fa48c1 
* feat(settleorder): implement check in settleorder command

disallow settlement of orders with PAID_HOLD_INVOICE status

* refactor(settleorder): implement check in settleorder command
@Catrya
Copy link
Member

Catrya commented Aug 16, 2024

Closed vía #567

@Catrya Catrya closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreaDiazCorreia AndreaDiazCorreia

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed 🪙 Reward in Sats ⚡
Projects
Developer Rewards ⚡👩‍💻
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grunch @AndreaDiazCorreia @Catrya