Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cancel message when an order maker cancels it #601

Merged
merged 3 commits into from
Nov 12, 2024
Merged

fix cancel message when an order maker cancels it #601

merged 3 commits into from
Nov 12, 2024

Conversation

Catrya
Copy link
Member

@Catrya Catrya commented Oct 26, 2024 •
edited
Loading

fix #482 #558
also fix cancel message when is the maker buyer who cancels the order in status waiting-payment

@Catrya Catrya changed the title fix cancel message when a order maker cancels it fix cancel message when an order maker cancels it Oct 26, 2024
knocte
knocte reviewed Oct 27, 2024
View reviewed changes
bot/commands.js Outdated Show resolved Hide resolved
@Catrya Catrya mentioned this pull request Nov 12, 2024
Closed
grunch
grunch approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@grunch grunch merged commit 8d6713f into main Nov 12, 2024
6 checks passed
@grunch grunch deleted the fixCancel branch November 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knocte knocte knocte left review comments

@grunch grunch grunch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message "You have cancelled the order..." should rather be "Order<orderId> has been cancelled..."
3 participants
@Catrya @grunch @knocte