Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio does not work for videos that were recently uploaded to RedGifs #513

Open
jdemph1971 opened this issue Jul 10, 2024 · 2 comments
Open
Labels
bug/fix Something isn't working

Comments

@jdemph1971
Copy link

Describe the bug
Audio does work for videos that were uploaded to RedGifs a long time ago. Audio does not work for videos that were recently uploaded to RedGifs. Note that it is the date that it was uploaded to (and encoded by) RedGifs that is important, not the date that it was posted to Reddit. In other words, you can have a video that was uploaded to RedGifs a long time ago but was recently (re-)posted to Reddit and that video will successfully play the audio. According to https://www.reddit.com/r/help/comments/18hl9n2/audio_in_redgifs_videos_is_no_longer_supported_on/ this is because RedGifs updated the encoding they use. This same issue happens in the official Reddit app. This issue does not happen in Narwhal, and did not happen in Apollo.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a post that has a video (that has audio) from RedGifs that was uploaded to RedGifs recently. There are many in the various NSFW subreddits. I did not want to post a specific link here since the content would be NSFW. If you want me to post example NSFW links that have this issue and I will do so.
  2. Play the video.
  3. The video will be silent.

Expected behavior
The video should successfully play the audio even for the new encoding that RedGifs now apparently uses.

Winston (please complete the following information):

  • Version Beta v1.1.5
  • Build 392

Device (please complete the following information):

  • Device: iPhone Xs Max
  • OS: iOS 17.5.1
@jdemph1971 jdemph1971 added the bug/fix Something isn't working label Jul 10, 2024
Copy link

linear bot commented Jul 10, 2024

@robigan
Copy link

robigan commented Sep 18, 2024

The reason for why RedGifs works on Narwhal and used to work on Apollo is/was because they properly interact with the RedGifs API to get the source video. Right now, the video returned by redgifs is the "video thumbnail" returned by the web page's metadata, apps properly wishing to embed RedGifs should either embed their own token, or request a temporary token at runtime. See https://api.redgifs.com/docs/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/fix Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants