Fix use of 'template' when actually calling non-template member #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ManifoldFR -- Could you please rebase this branch to the latest 'devel' branch? The CI failures might be related to this. Thanks! |
overloaded member of Eigen object + creates a compile issue with Eigen 3.3.7
for more information, see https://pre-commit.ci
Done, cheers |
|
@cmastalli do I need to update the changelog for this? |
Let's not bother to update the changelog in this PR, especially because it fixes a bug that has not been released. |
ManifoldFR
added a commit
to edantec/aligator
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed line of code tried to call a templated member for an Eigen fixed-size block expression but instead calls the dynamic-sized overload.
This created a compile issue with Eigen 3.3.7 and clang 16.0.6.