Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add codeql config #2705

Merged
merged 8 commits into from
Sep 4, 2024
Merged

ci: add codeql config #2705

merged 8 commits into from
Sep 4, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Sep 3, 2024

Adds CodeQL config, which automatically scans for security vulnerabilities.

Python and Typescript work without custom config, but kotlin required some.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@anna-parker
Copy link
Contributor

@corneliusroemer I see this error when I look into the security section on github:
image - will this PR fix this or is github/codeql-action#2378 (comment) potentially still causing issues?

Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful!

@corneliusroemer
Copy link
Contributor Author

Great question @anna-parker - I should have been explicit.

  1. I set up codeql with default settings (no config file)
  2. This ran, it worked for Python and TS, it failed for kotlin
  3. This is the notification you see, that something failed
  4. I then switched to advanced config (having explicit config file)
  5. This is the PR here
  6. Based on how codeql works, the advanced config doesn't make the warning disappear until it's merged into main
  7. The codeql config here ran on this branch and it worked, so it shouldn't error again.

Hope this makes sense!

@corneliusroemer corneliusroemer merged commit c2bd05a into main Sep 4, 2024
15 checks passed
@corneliusroemer corneliusroemer deleted the codeql branch September 4, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants