Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyValueMap easier to populate/transform to #26

Open
peter-lyons-kehl opened this issue May 27, 2022 · 0 comments
Open

KeyValueMap easier to populate/transform to #26

peter-lyons-kehl opened this issue May 27, 2022 · 0 comments

Comments

@peter-lyons-kehl
Copy link
Contributor

Thank you for Tags::parse(..).

We probably don't need/want any out-of-the box parsing for key-value pairs, since the separators... may vary. But how about

  • KeyValueMap::new(given_map: HashMap) that would take its ownership (especially since the current implementation is a wrapper), and optionally:
  • a conversion function like KeyValueMap::new(it: Iterator<Item = (impl String, impl String)>) -> Self? (Or implementing TryFrom, but something tells me that TryFrom is not a good way to go here.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant