Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare HMAC of request body with X-Hub-Signature header #21

Open
charlie-s opened this issue Jul 17, 2014 · 1 comment
Open

Compare HMAC of request body with X-Hub-Signature header #21

charlie-s opened this issue Jul 17, 2014 · 1 comment

Comments

@charlie-s
Copy link

I think it would be smart to generate the HMAC of the request body using the secret key that's set when configuring the webhook and compare it with the X-Hub-Signature header that GitHub sends in the request.

kumy added a commit to kumy/Github-Auto-Deploy that referenced this issue Apr 18, 2015
@NiclasLindqvist
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants