Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendlier handling of non 200 response codes #30

Open
jsvd opened this issue Feb 19, 2021 · 2 comments · May be fixed by #31
Open

Friendlier handling of non 200 response codes #30

jsvd opened this issue Feb 19, 2021 · 2 comments · May be fixed by #31
Labels
enhancement New feature or request

Comments

@jsvd
Copy link
Member

jsvd commented Feb 19, 2021

Currently anything that's not a 200 means the plugin won't process headers or the body.
In many cases this isn't ideal as these are still valuable for debugging / observability purposes.

A way to improve this would be to always process the body and headers, but only apply the filter_matched method on successful requests (200 status code)

@jsvd jsvd added the enhancement New feature or request label Feb 19, 2021
@jsvd jsvd linked a pull request Feb 19, 2021 that will close this issue
@emilymcalister
Copy link

Linking new issue - did not see this when raising: elastic/logstash#14368

@C0rn3j
Copy link

C0rn3j commented Jan 22, 2024

There is no way to show body value, not even TRACE debug level shows it, this caused me a lot of frustration and ending up having to set up netcat listener just to see what was going wrong as my endpoint does not necessarily support easy access to raw data.

Status code nor response body nor response headers are saved on error, which is very frustrating.

It would be nice to be able to optionally save the request body too.

My reponse body contains a JSON with details when an error occurs, with this plugin there is no way to use them much less parse them.

Whatever behavior is decided should be communicated on the documentation, currently it doesn't mention it, nor that it throws a _httprequestfailure tag.

https://www.elastic.co/guide/en/logstash/current/plugins-filters-http.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants