Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keepalive setting conditional #106

Open
gagara opened this issue Feb 2, 2019 · 0 comments
Open

Make keepalive setting conditional #106

gagara opened this issue Feb 2, 2019 · 0 comments

Comments

@gagara
Copy link

gagara commented Feb 2, 2019

Keepalive option at https://github.com/logstash-plugins/logstash-input-http/blob/master/src/main/java/org/logstash/plugins/inputs/http/NettyHttpServer.java#L57 should not be hardcoded, but it must respect "Connection" header.
If in plugin configuration user provides custom response header as

response_headers => {"Connection" => "close"}

then in according to https://tools.ietf.org/html/rfc7230#section-6.6 server must close connection

A server that sends a "close" connection option MUST initiate a close
of the connection (see below) after it sends the response containing
"close". The server MUST NOT process any further requests received
on that connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant