Different behaviour for ssl_endpoint_identification_algorithm between input and output

[andsel]

With PR #8 changed the behavior of ssl_endpoint_identification_algorithm for the output, now it's empty it disable the truststore but the input keeps the old behavior, nil check instead of empty check:

logstash-integration-kafka/lib/logstash/inputs/kafka.rb

Line 383 in ba70405

props.put("ssl.endpoint.identification.algorithm", ssl_endpoint_identification_algorithm) unless ssl_endpoint_identification_algorithm.nil?

• Version: >= 10.2.0
• Operating System:
• Config File:

input {
	tcp {
		port => 12345
	}
}
output {
	kafka {
		bootstrap_servers => ["${AMQ_METRIC_HOST_LB}"]
		codec => json
		topic_id => "cep_metric_rapid_corporate"
		security_protocol => "SSL"
		ssl_endpoint_identification_algorithm => ""
		ssl_key_password => "${CERT_PASSWORD}"
		ssl_keystore_location => "${KEYSTORE_ADDRESS}"
		ssl_keystore_password => "${CERT_PASSWORD}"
		ssl_keystore_type => "jks"
		ssl_truststore_location => "${TRUSTSTORE_ADDRESS}"
		ssl_truststore_password => "${CERT_PASSWORD}"
		ssl_truststore_type => "jks"
	}
}

• Steps to Reproduce: run Logstash the above pipeline config with --debug and in log for kafka output appears:

	ssl.trustmanager.algorithm = PKIX
	ssl.truststore.location = null
	ssl.truststore.password = null
	ssl.truststore.type = JKS

while in input keeping always ssl_endpoint_identification_algorithm => "" it prints:

	ssl.trustmanager.algorithm = PKIX
	ssl.truststore.location = /path/to/truststore.jks
	ssl.truststore.password = [hidden]
	ssl.truststore.type = jks

[andsel]

cc @kares

[kares]

Thanks Andrea, makes sense - reviewing #8 should have realized it's also used for the input.