Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add safe bank access handling in single and double stream blocks #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Limbicnation
Copy link

No description provided.

@logtd
Copy link
Owner

logtd commented Dec 4, 2024

Did you encounter an error with the bank code as is?

edit: ah I see, when the step counts don't match up. This was intentional to alert the user that the configuration is incorrect, but I agree it could be better

@Limbicnation
Copy link
Author

@logtd Hi thank you for your message. Apologies for my late reply. When running the workflow I'm running into the error:

RuntimeError: Key and Value must have the same sequence length

I have the same guidance and Steps values for both unsampling and sampling workflow sections. Maybe you can help me to resolve this?

@Limbicnation
Copy link
Author

@logtd I've pushed some experimental changes to handle the sequence length mismatch error: Limbicnation@9248f98

@logtd
Copy link
Owner

logtd commented Dec 12, 2024

Hey, thanks for opening the PR. I had to make some changes to adjust the layers for fireflow. I believe it covered your issue with the bank being unsafe, but let me know if it is still an issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants