Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebhookProjectTranslationUpdated and WebhookProjectTranslationProofread are missing the "action" field #462

Open
stalar opened this issue Jun 28, 2024 · 8 comments
Assignees

Comments

@stalar
Copy link

stalar commented Jun 28, 2024

Describe the bug
The types WebhookProjectTranslationUpdated and WebhookProjectTranslationProofread are missing the "action" field.

@bodrovis bodrovis self-assigned this Jun 28, 2024
@bodrovis
Copy link
Collaborator

From what I can see, project.translation.updated does not have an action field, at least I don't see one when firing this webhook. Do you observe a different result?

@stalar
Copy link
Author

stalar commented Jun 28, 2024

I think all webhook events should have an action field to tell where the event originated from.

@stalar
Copy link
Author

stalar commented Jun 28, 2024

If action is not available on these events, then this bug report is about that :-)

@stalar
Copy link
Author

stalar commented Jun 28, 2024

Although not documented, we expect action === 'api' whenever the event was sent as a result of us calling the api

@bodrovis
Copy link
Collaborator

I don't think action is present for all events, to be honest. I'll reach out to the team but if that's the case then we'll need to raise this request elsewhere (as it's not related to the sdk itself). Sorry for this confusion, I'll ask the team now

@bodrovis
Copy link
Collaborator

I've forwarded this request to the corresponding team, and will let you know once this is resolved 👍

@bodrovis
Copy link
Collaborator

bodrovis commented Jul 1, 2024

I had a chat with the team who's managing these webhooks and unfortunately it does not seem this will be resolved soon. They've added it to the pipeline but I really can't say for sure what's the ETA. If this feature is important for you, I'd recommend talking to csm or the support team directly to provide more context

@stalar
Copy link
Author

stalar commented Jul 1, 2024

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants