Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eyeglass support #17

Open
polarathene opened this issue Jun 20, 2015 · 6 comments
Open

Eyeglass support #17

polarathene opened this issue Jun 20, 2015 · 6 comments

Comments

@polarathene
Copy link

Any chance of providing support for Eyeglass? It's a JS equivalent to Compass from what I understand. The support would make it possible to use Breakpoint Slicer via LibSass on Node.js I think?

Details on how to support Eyeglass is here: https://github.com/sass-eyeglass/eyeglass/blob/master/docs/eyeglass_modules/index.md#bringing-eyeglass-to-existing-projects

@ManasN
Copy link

ManasN commented Jun 22, 2015

I am counting on support for Eyeglass too :) thanks.

@lolmaus
Copy link
Owner

lolmaus commented Nov 21, 2015

Hi.

I've published the project on npm and created an Eyeglass config. I'm not using Eyeglass yet, so I dunno if the config is correct.

Can you please try installing and using it via Eyeglass?

@stevetweeddale
Copy link

Yeah, it doesn't work :(

It appears that for some reason going via eyeglass causes node-sass to choke on the indented syntax you use. Looking around, this issue looks like it might be it: sass/node-sass#1192

@stevetweeddale
Copy link

I've just whipped up a quick fork that sidesteps the issue by converting to the scss bracketed syntax.

I don't care much for the older syntax, but I know people sometimes feel strongly about such things. So I can make it a pull request if you'd like to exchange indented sass syntax for working eyeglass support! Otherwise, once that issue is fixed you should be golden.

The other change I made was addressing the following complaint made by eyeglass on compilation:

The following modules did not declare an eyeglass version:
  breakpoint-slicer
Please add the following to the module's package.json:
  "eyeglass": { "needs": "^0.8.3" }

@lolmaus
Copy link
Owner

lolmaus commented Jul 8, 2016

This sucks. :( All those curlies and semicolons do not bring any benefit, only visual noise.

OK, I'll accept a PR.

@lolmaus
Copy link
Owner

lolmaus commented Feb 22, 2021

I'm sorry for neglecting this.

I have rewritten Breakpoint Slicer from scratch with support for Sass modules.

Please tell me if it works with Eyeglass. If it doesn't, please file a PR and I promise I'll tackle it within a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants