TWiL 39 #164
Merged
TWiL 39 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xry111
reviewed
Mar 6, 2024
| 为 LoongArch CAS 操作的输入[做了符号扩展](https://github.com/llvm/llvm-project/pull/83656)。 | ||
| 此额外处理对拥有原生 CAS 支持的 LA664 微架构是不必要的；龙芯方面暂时没搞，[xen0n] 准备近期做掉。 | ||
|
|
||
| [leecheechen] [避免了](https://github.com/llvm/llvm-project/pull/82984) |
There was a problem hiding this comment.
I've some doubts about this change.
IIUC an intrinsic should be simply mapped to the underlying instruction. I.e. if an user uses the intrinsic on an invalid operand, (s)he's invoking undefined behavior and we don't need to guarantee a thing.
In GCC we don't clear those bits for __builtin_lasx_xvpermi_q.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.