Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML output #5

Closed
bajtos opened this issue May 11, 2016 · 1 comment
Closed

HTML output #5

bajtos opened this issue May 11, 2016 · 1 comment
Assignees
@davidcheung
Labels
feature
Milestone
#Epic: Production...

Comments

@bajtos
Copy link
Member

bajtos commented May 11, 2016 •
edited
Loading

Implement HTML output using hard-coded templates shipped as part of this module.

See #1 for inspiration.

Customizing HTML templates is out of scope of this issue, see #3.
@bajtos bajtos added the feature label May 11, 2016
@loay loay mentioned this issue May 11, 2016
Open
@bajtos bajtos mentioned this issue May 11, 2016
Merged
@bajtos bajtos changed the title Support HTML output HTML output May 12, 2016
@bajtos bajtos added the #plan label May 12, 2016
@davidcheung
Copy link
Contributor

davidcheung commented May 17, 2016 •
edited
Loading

  • setup structure to handle accepted headers ( should be applicable to all accepted )
  • template? ejs? jade?

https://github.com/strongloop/strong-error-handler/blob/d0a2b1023d2958d908c8fed5178016228995f7e1/index.js#L103-L155

Strong-remoting handling accepts
https://github.com/strongloop/strong-remoting/blob/aa391d2e65460196ae2a59493f9dd4844622f35d/lib/http-context.js#L546-L579

@bajtos bajtos added tob-4-weeks and removed #plan labels May 17, 2016
@davidcheung davidcheung mentioned this issue May 31, 2016
Merged
@davidcheung davidcheung added #review and removed #wip labels May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcheung davidcheung

Labels
feature
Projects
None yet
Milestone
#Epic: Production Error Handler
Development

No branches or pull requests
2 participants
@bajtos @davidcheung