Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-sort order is wrong #844

Open
omkarbandkar opened this issue Jan 9, 2019 · 0 comments
Open

aria-sort order is wrong #844

omkarbandkar opened this issue Jan 9, 2019 · 0 comments

Comments

@omkarbandkar
Copy link

omkarbandkar commented Jan 9, 2019

the aria-sort value is set to descending even when ascending sort is applied and vice-versa.

In file stSort.js on line number 90
.attr(ariaSort, newValue.reverse ? ariaSortAscending : ariaSortDescending);
should be changed to
.attr(ariaSort, newValue.reverse ? ariaSortDescending : ariaSortAscending );

since reverse indicated descending order, when reverse is true descending label should be shown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant