Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning support. #39

Open
hansgru opened this issue Oct 2, 2013 · 6 comments
Open

Add versioning support. #39

hansgru opened this issue Oct 2, 2013 · 6 comments

Comments

@hansgru
Copy link

hansgru commented Oct 2, 2013

Please add support for versions (and tags) to be able to map the messages to the correct KendoUI version (since it's a moving target).

regards.

@loudenvier
Copy link
Owner

Given the nature of JavaScript it will be perfectly possible to maintain a single version with full backwards compatibility. We just need to add a new entry, instead of replacing a changed localizable item. This way it will work despite the new changes. Unless they did something extreme with the codebase.

@hansgru
Copy link
Author

hansgru commented Oct 2, 2013

Unless they did something extreme with the codebase.

It must not be extreme. It's enough whey they rename action labels from one version to the other, thus having the requirement to have 2 different translations for the two versions.

I'm also very thankful for this project, but still don't understand why isn't this in the Kendo UI core?

@loudenvier
Copy link
Owner

There's no problem at all if they rename action labels from one version to another. All we need to do is to keep both the old label and the new one inside kendo-global. That's what I said when I mumbled about "given JavaScript nature". It won't complain if we have "extra" labels localized. As long as we have them all. If a new action label is added in a new version, we shouldn't remove the old and rename it to the new one. We should only ADD the new one, and keep the old label. This way it will work on both, and we don't need to keep one version for each version of KENDO.

As for why it isn't in Kendo UI core, I tired of heated debated with the Kendo UI team, as they don't seem to recognize that Kendo is NOT ONLY FOR ENGLISH SPEAKING COUNTRIES! So I had to find a way to do it myself, and then kendo-global was born (and shared!)

I have absolutely nothing to do with the Telerik team.

@hansgru
Copy link
Author

hansgru commented Oct 2, 2013

There's no problem at all if they rename action labels from one version to another. All we need to do is to keep both the old label and the new one inside kendo-global. That's what I said when I mumbled about "given JavaScript nature".

Sorry but I don't get it :). What if in the next version, the following label:
sortAscending: "Sort Ascending" is changed into sortAscending: "Sort Ascending BlahBlah" by the Kendo team? How would one ensure that both the old label and the new label would work since there's only one key ?

I have absolutely nothing to do with the Telerik team.

I know :). I was just wondering why the Kedo team wasn't doing anything, since it's all here, and they just need to pull this to their "cultures" sub-directory.

As for why it isn't in Kendo UI core, I tired of heated debated with the Kendo UI team,

Thanks for sharing the background. I also had the feeling that they run in "auto-pilot mode" regarding other issues critical for business web applications. Also any constructive observations are cut with the "use the UserVoice and vote ..." answer.

I had to find a way to do it myself, and then kendo-global was born (and shared!)

Thank you for the solution.

regards.
OT: Even if KendoUI is nice, I'm using for new projects http://w2ui.com/web/ now. It's quite good and open source, and it seems quite a good alternative to KendoUI (except for the missing IE8 support).

@loudenvier
Copy link
Owner

Hi Hans,

Now I understand what you are saying... But, I'm really not bothered by changes in the values of a label... I think that we should always stick with the newer one, whenever possible. Of course, if they "redefine" one label to mean another thing in a new version, then this is a problem that would require versioning. So far I haven't stumbled on this yet.

I mean that if they change
sortAscending: "Bla" to sortAscendingSomething: "Bla bla"... Then we keep sortAscending and sortAscendingSomething :-)

Thanks for the link. I'll take a closer look on the w2ui... But the thing is, I'm not even using Kendo anymore! I'm very happy with using any JavaScript MVC framework + ASP.NET MVC 4 + jQuery + jQuery UI... I don't really see much reason in starting a project based on KendoUI...

@marklagendijk
Copy link

In my opinion this is a non-issue. It is about adding support for solving a problem, which isn't an actual current problem. I propose to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants