Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ESLint to the project and resolve the ESLint errors #293

Open
bhavik001 opened this issue Nov 27, 2023 · 13 comments
Open

Implement ESLint to the project and resolve the ESLint errors #293

bhavik001 opened this issue Nov 27, 2023 · 13 comments
Assignees
@bhavik001

Comments

@bhavik001
Copy link
Contributor

bhavik001 commented Nov 27, 2023 •
edited
Loading

Hello!
I need to implement linting feature to this repository and also solve the errors that will arise after implementing ESLint. Can someone assign me this issue. So, that I can start working on it.
@bhavik001
Copy link
Contributor Author

bhavik001 commented Dec 7, 2023 •
edited
Loading

Hello!
I was implementing the ESLint Feature and I have just try to implement with on folder that is test and I am getting the below errors. Where did Tools came from. There is one solution for the Tools I can make it as a global variable in the eslintrc.js file. Then it will be okay. The second error is done. This is declare but the value never used. So, the solution is to remove.

There are so many error like this. If you give me permission to edit files than I can do it.
Please reply.

image

@lovasoa
Copy link
Owner

lovasoa commented Dec 8, 2023

Yes you'll need to edit the files.

Tools is defined here: https://github.com/lovasoa/whitebophir/blob/master/client-data/js/board.js#L27

@bhavik001 bhavik001 mentioned this issue Dec 9, 2023
Closed
3 tasks
@bhavik001
Copy link
Contributor Author

Hey,
I have created a pull request please look into it and also I am creating a document which consist of the line number and error that I have disable. Also don't close this pull request after merging it.

@bhavik001 bhavik001 changed the title Add Linting Implement ESLint to the project and resolve the ESLint errors Dec 9, 2023
@lovasoa
Copy link
Owner

lovasoa commented Dec 9, 2023

you closed the pr

@bhavik001 bhavik001 mentioned this issue Dec 9, 2023
Closed
3 tasks
@bhavik001
Copy link
Contributor Author

bhavik001 commented Dec 9, 2023 •
edited
Loading

Remaining ESLint Error.txt
Hey
I have created new pull request and the above file consist of the changes we have to do. For now I have disable ESLint for that particular line.

Also it is ready to merge

@lovasoa
Copy link
Owner

lovasoa commented Dec 9, 2023

Hello! I don't think we can consider this ready to merge until you fix the actual eslint errors. You can't just disable lints everywhere and call it a day.

@bhavik001
Copy link
Contributor Author

Yup, I am continue my work. Just need some help to understand some part of the code.

@lovasoa
Copy link
Owner

lovasoa commented Dec 9, 2023

Sure, let me know what you need help with

@bhavik001
Copy link
Contributor Author

bhavik001 commented Dec 11, 2023 •
edited
Loading

Hey,
I have updated the file and also dealt with all the errors. Please review the code and also the code is ready to merge.

@bhavik001
Copy link
Contributor Author

Hey,
I have updated the file and remove everything as mention by you. Please review once and let me know if I have to make changes.

@bhavik001
Copy link
Contributor Author

Hey
Please let me know if the changes I have made is good to go or I should revert it. I have replied you with the explanation on the changes.

@bhavik001
Copy link
Contributor Author

Hey
Please review the last commit that I have pushed and let me know if that is good or need more modification. Also let me know if it is good for merge.

@lovasoa
Copy link
Owner

lovasoa commented Dec 12, 2023

I receive the notifications from the pull request already. No need to keep posting in this issue every time you update the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhavik001 bhavik001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding ESLint to the project and solving the ESLint Errors
2 participants
@lovasoa @bhavik001