Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tlgen] tlgen completely broken as a standalone util #25356

Open
luposmi opened this issue Nov 22, 2024 · 2 comments · May be fixed by #25455
Open

[tlgen] tlgen completely broken as a standalone util #25356

luposmi opened this issue Nov 22, 2024 · 2 comments · May be fixed by #25455
Assignees

Comments

@luposmi
Copy link

luposmi commented Nov 22, 2024

Description

Hi,
just wanted to say that the tlgen.py util currently always throws

Traceback (most recent call last):
  File "/home/krusekamp/vicuna-multicore/../repos/opentitan/util/tlgen.py", line 98, in <module>
    main()
  File "/home/krusekamp/vicuna-multicore/../repos/opentitan/util/tlgen.py", line 71, in main
    xbar = tlgen.validate(obj)
  File "/home/krusekamp/repos/opentitan/util/tlgen/validate.py", line 312, in validate
    node.addr_spaces = {nodeobj["addr_space"]}
KeyError: 'addr_space'

when using it as a standalone feature (where you do not generate addr_space by topgen).
To test it, just run tlgen on the example hjson file.
Before you can do that, you need to rename base_addr -> base_addrs in that file, as for some reason that part of the API was changed.

The commit 21e0759 still works.

Have a nice day,
Ben

@rswarbrick
Copy link
Contributor

Thanks for the report. The attached PR should fix things.

@rswarbrick rswarbrick self-assigned this Nov 29, 2024
@luposmi
Copy link
Author

luposmi commented Nov 29, 2024

Thanks!

Just tested it out and adapted my own config to resemble the structure of the new example, and it compiled with no issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants