[util,tlgen] Lots of changes to get tlgen examples working again #25455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, you get a confusing error message if you don't
supply it. The original author also obviously imagined that
log.error() would end the program, but it doesn't! Bail properly if
needed.
Finally, tighten up the test with is_dir() because Path('') gives the
current directory (which is a directory...)
Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
added
the
Component:Tooling
|
Ahah! I just looked more closely at when the schema changed. The change was only merged into master last month. |
Signed-off-by: Rupert Swarbrick <[email protected]>
This was ripped out with commit 1299fa1. Signed-off-by: Rupert Swarbrick <[email protected]>
Also, allow a situation where node is an instance of Host but doesn't have an addr_space argument (which previously threw a KeyError). Signed-off-by: Rupert Swarbrick <[email protected]>
This changed in topgen last year and it looks like we hadn't updated the examples to match. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
tlgen-addr-spaces
branch
from
b024ff7
to
9fdd350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema of the hjson input changed last year (see commit 3ff8ebd) and it looks like we didn't update the examples.
Fixes #25356.