Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Improve install instructions #244

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Croydon
Copy link
Contributor

@Croydon Croydon commented Apr 19, 2024

This improves the CMake install instructions. The destination paths should not be hard-coded, but set as variables via GnuInstallDirs.

This is particularly important for package managers like Conan that require files to be installed in a custom directory.

PS: Merging this will make the Conan enet package patch free for the first time. Although other package managers like vcpkg will still carry additional CMake patches for now.


@Croydon Croydon force-pushed the cmake_improve_installs branch from e19d519 to 3fdb9cb Compare April 19, 2024 03:38
@Croydon Croydon marked this pull request as ready for review April 19, 2024 03:41
@lsalzman lsalzman merged commit 4ce1625 into lsalzman:master Apr 24, 2024
6 checks passed
@Croydon Croydon deleted the cmake_improve_installs branch April 24, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants