Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in intervals() for <= 3 events #168

Open
chguiterman opened this issue Jul 22, 2020 · 2 comments
Open

Error in intervals() for <= 3 events #168

chguiterman opened this issue Jul 22, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@chguiterman
Copy link
Contributor

When a composite has <= 3 fire events, intervals() fails with this message:

Error in stats::shapiro.test(x$intervals) : 
  sample size must be between 3 and 5000
@brews
Copy link
Member

brews commented Jul 24, 2020

Is this a common issue?

stats::shapiro.test is pretty solid, maybe we just should catch this error and report NA, @chguiterman ?

@brews brews added the bug Something isn't working label Jul 24, 2020
@chguiterman
Copy link
Contributor Author

That's a good idea @brews. We still want to be able to report the mean, but yes the statistical test of it is useless and should be skipped.

@brews brews added this to the v0.6.0 milestone Aug 3, 2020
@brews brews modified the milestones: v0.6.0, v0.7.0 Feb 24, 2021
@brews brews added the good first issue Good for newcomers label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants