Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad rugs when using plotting facets. #21

Open
brews opened this issue Sep 8, 2015 · 4 comments
Open

Bad rugs when using plotting facets. #21

brews opened this issue Sep 8, 2015 · 4 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@brews
Copy link
Member

brews commented Sep 8, 2015

Rugs and facets do not work well together (if at all). I imagine this has to do with how we hacked our way around spacing our rugs with single plots...

Anyways, we also have a problem with needing to define a independent rug for each facet subplot. i.e. facets do not share the same rug.

@brews brews added the bug Something isn't working label Sep 8, 2015
@brews brews self-assigned this Sep 8, 2015
@brews brews added this to the 0.1.0 milestone Sep 9, 2015
@brews brews changed the title Poor plotting when using facet_wrap with rugs. Bad rugs when using plotting facets. Sep 9, 2015
@brews brews removed this from the 0.1.0 milestone Sep 15, 2015
@brews brews removed their assignment Sep 15, 2015
@brews
Copy link
Member Author

brews commented Dec 3, 2015

This is an issue upstream with ggplot2.

@brews brews added the wontfix label Feb 19, 2016
@brews brews modified the milestone: v0.2.0 Sep 2, 2016
@brews
Copy link
Member Author

brews commented Sep 2, 2016

There has been a major release to ggplot2 with changes that might help to fix this. One other possible work around is creating a composite object and then append that to the end of a series that is about to be used for plotting.

@brews brews removed the wontfix label Sep 2, 2016
@brews brews removed this from the v0.2.0 milestone Feb 8, 2017
@chguiterman
Copy link
Contributor

@brews I have a possible fix for this. I was able to make rugs work on facets, the next challenge that emerged, however was that because ggplot treats the rug as y-axis data - a series in the case of plot_demograph() - it resorts the series factor levels. That means that any use of sort.fhx() prior to calling plot_demograph() is lost/ignored. The solution is to build and an internal sort variable in plot_demograph().
I wasn't sure the demand for this option (to plot composite rugs on facets) justified the effort and change in burnr. I'm willing to take it up (sometime) if we feel it adds a lot of value.

See the graphic here: https://chguiterman.github.io/Misc/burnr_facet_rug_composite.png

@brews
Copy link
Member Author

brews commented Jul 10, 2020

Thanks @chguiterman, I haven't heard anyone complain about this. Has this been an issue for you, in the wild?

@brews brews added the help wanted Extra attention is needed label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants