Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Convolution Subsampling? #1

Open
fmac2000 opened this issue Sep 28, 2023 · 1 comment
Open

Missing Convolution Subsampling? #1

fmac2000 opened this issue Sep 28, 2023 · 1 comment

Comments

@fmac2000
Copy link

Hi Lucas,
I'm looking over the code and I believe you have missed the two convolution subsampling layers in conformer.py,

4.1.1. NON-STREAMING MODELS The model has two convolution layers at the bottom which provide 4 times temporal-dimension reduction for the input sequences. The rest of the layers are a stack of Conformer models. We explore 0.6B model size which is extensively studied in the previous works. The model contains 24 layers of Conformer models.

Screenshot 2023-09-28 at 18 47 25

If you'd like I can create a pull request and implement this for you now.
Thanks - If I've misunderstood the paper, please call me out! 😅

@lucasnewman
Copy link
Owner

@fmac2000 Yes, please, a PR would be great! I was aware of them in the paper but I skipped them for simplicity and downsampled in the feature extractor to get it off the ground. I would love to have it reflect the paper as closely as possible though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants