-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint the code with pylama #67
Comments
Feel free to add a job on travis or circleci.com |
I have made a pull request with simple pylama configuration (that will configure pylama with mccabe, pycodestyle and pyflakes linters). Next I'll figure out how to configure Travis (but I suppose you will have to enable travis builds yourself as a repo owner). |
OK, I have also added a Travis configuration in #73. Could you enable build on Travis (it should hopefully detect this branch whenever there will be a new push)? |
@mjenczmyk very good job, Thx! I'll test it after work and do merge |
Already merged |
Could you reopen this? There is still pylint and pydocstyle to be enabled. Have we checked that Travis CI runs pylama when pull request is made/updated? Also, from now we shouldn't push directly to master (can we secure this branch from pushing and leave pull requests as the only way of updating this?). |
ok, sorry : )
|
Thanks, Travis is configured indeed. |
As code in this repo is becoming more and more compliant with PEP8 it would be nice to use pylama to lint it - it's easy to configure Travis to run pylama on every PR and warn about style issues in PR changes. Existing and harder to resolve issues could be ignored in pylama configuration and resolved later.
To be done:
The text was updated successfully, but these errors were encountered: