Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint the code with pylama #67

Open
4 of 6 tasks
mjenczmyk opened this issue Aug 28, 2017 · 8 comments
Open
4 of 6 tasks

Lint the code with pylama #67

mjenczmyk opened this issue Aug 28, 2017 · 8 comments
Assignees

Comments

@mjenczmyk
Copy link
Collaborator

mjenczmyk commented Aug 28, 2017

As code in this repo is becoming more and more compliant with PEP8 it would be nice to use pylama to lint it - it's easy to configure Travis to run pylama on every PR and warn about style issues in PR changes. Existing and harder to resolve issues could be ignored in pylama configuration and resolved later.

To be done:

  • use pylint linter;
  • use mccabe linter;
  • use pycodestyle linter;
  • use pyflakes linter;
  • use pydocstyle linter;
  • configure Travis task;
@luk6xff
Copy link
Owner

luk6xff commented Sep 3, 2017

Feel free to add a job on travis or circleci.com

@mjenczmyk
Copy link
Collaborator Author

I have made a pull request with simple pylama configuration (that will configure pylama with mccabe, pycodestyle and pyflakes linters). Next I'll figure out how to configure Travis (but I suppose you will have to enable travis builds yourself as a repo owner).

@mjenczmyk
Copy link
Collaborator Author

OK, I have also added a Travis configuration in #73. Could you enable build on Travis (it should hopefully detect this branch whenever there will be a new push)?

@luk6xff
Copy link
Owner

luk6xff commented Sep 5, 2017

@mjenczmyk very good job, Thx! I'll test it after work and do merge

@luk6xff
Copy link
Owner

luk6xff commented Sep 13, 2017

Already merged

@luk6xff luk6xff closed this as completed Sep 13, 2017
@mjenczmyk
Copy link
Collaborator Author

Could you reopen this? There is still pylint and pydocstyle to be enabled.

Have we checked that Travis CI runs pylama when pull request is made/updated?

Also, from now we shouldn't push directly to master (can we secure this branch from pushing and leave pull requests as the only way of updating this?).

@luk6xff luk6xff reopened this Sep 17, 2017
@luk6xff
Copy link
Owner

luk6xff commented Sep 17, 2017

ok, sorry : )

  1. Yeah, check this out: https://travis-ci.org/igbt6/Packt-Publishing-Free-Learning

@mjenczmyk
Copy link
Collaborator Author

Thanks, Travis is configured indeed.

@mjenczmyk mjenczmyk self-assigned this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants