Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to w3c standard #230

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Update to w3c standard #230

wants to merge 10 commits into from

Conversation

lukasoppermann
Copy link
Owner

@lukasoppermann lukasoppermann commented Sep 8, 2022 •
edited
Loading

This fixes #229 and #200

  • add standard deprecated to dropdown selection
  • fix test
  • examples for style dictionary conversion (parser, etc.)
  • manually test standard and standard deprecated
  • update value to $value
  • update type to $type
  • update description to $description
  • update extensions to $extensions
  • check tokens
    • typography
    • duration
    • size
    • color
    • ...
  • add w3c transition
  • add w3c typography
  • add deprecated to custom formats
  • change values to w3c valid values

@lukasoppermann lukasoppermann changed the title draft of w3c update Update to w3c standard Sep 8, 2022
@coveralls
Copy link

coveralls commented Sep 8, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 4428142244

  • 12 of 104 (11.54%) changed or added relevant lines in 9 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-18.2%) to 63.281%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utilities/convertColor.ts 0 1 0.0%
src/transformer/tokenExtensions.ts 0 2 0.0%
src/utilities/prepareExport.ts 0 2 0.0%
src/extractor/extractFonts.ts 7 10 70.0%
src/transformer/standardTransformerV1.deprecated.ts 0 13 0.0%
src/transformer/TokenTransformer.ts 0 21 0.0%
src/transformer/standardTransformerV2.ts 0 50 0.0%
Files with Coverage Reduction New Missed Lines %
src/transformer/tokenExtensions.ts 1 0%
src/utilities/convertColor.ts 1 87.5%
Totals Coverage Status
Change from base Build 3017694185: -18.2%
Covered Lines: 488
Relevant Lines: 742
💛 - Coveralls

@lukasoppermann lukasoppermann self-assigned this Sep 8, 2022
@lukasoppermann lukasoppermann added the Feature New feature or request label Sep 8, 2022
derekwsgray
derekwsgray reviewed Sep 22, 2022
View reviewed changes
src/config/format.ts Outdated Show resolved Hide resolved
@lukasoppermann lukasoppermann marked this pull request as ready for review October 23, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwsgray derekwsgray derekwsgray left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@lukasoppermann lukasoppermann

Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update standard format to follow specs
3 participants
@lukasoppermann @coveralls @derekwsgray