Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mode for tokens is off by default and Unable to toggle Mode in settings #319

Open
zackcon opened this issue Nov 19, 2024 · 3 comments
Open
Labels
Improvement Enhancement or code cleanup

Comments

@zackcon
Copy link

zackcon commented Nov 19, 2024

The settings toggle for the mode in token does not seem to actually save or persist as it will revert back to off after refresh and exports don't seem to respect it being toggled to on. We also noticed that with the new mode toggle, it was being set to off by default which caused pain in our org as we were relying on that mode to transpile variables correctly in our codebase. We are currently unable to export at this time until we can enable that setting.

@zackcon
Copy link
Author

zackcon commented Nov 19, 2024

It seemed like the settings modal was cutting of the "save changes" button which is why the toggle wasn't persisting. I re-installed the extension and it now shows correctly. I previously was unable to scroll within it. However the issue stills stands with mode being off by default when it seemed like before the update to add the toggle, it was on by default

@0m4r
Copy link
Collaborator

0m4r commented Nov 19, 2024

Ho @zackcon I will be looking into it.

Can you please confirm you experience the same problem with both new toggles or only with one of them?

The reason they are "off" by default is not to alter the last (correct?) behavior... but it may be an option to set the one about the mode in the token variable vale on by default (as it seems quite a common need)

What do you think @lukasoppermann?

@0m4r
Copy link
Collaborator

0m4r commented Nov 19, 2024

It seemed like the settings modal was cutting of the "save changes" button which is why the toggle wasn't persisting. I re-installed the extension and it now shows correctly. I previously was unable to scroll within it. However the issue stills stands with mode being off by default when it seemed like before the update to add the toggle, it was on by default

My prev answer was before this, part of it is not valid, I guess!
Great to hear the problem is (partially) solved...

The user experience can definitely be improved. Will try to make it better.

Thanks for the feedback!

@lukasoppermann lukasoppermann added the Improvement Enhancement or code cleanup label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Enhancement or code cleanup
Projects
None yet
Development

No branches or pull requests

3 participants