-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing counters for certain units #2
Comments
Hi @Gvanderl Glad you like the tool. Was just a quick weekend project initially. The data was pulled from some other aoe counter website, I can't quite remember, they just had the json file sitting there on an endpoint which made life easy. Building a scraper script to hit the official AOE2 Wiki sounds a lot more reliable, in terms of keeping this up to date. It would be awesome if we could click a button and get an updated list of units/counters. Ideally this would be apart of the build/export step before publishing the site. But would be more than happy if you wanted to build a python based script, purely for scraping data and updating the units.json file. If you think there is any extra data that the wiki provides that you think might be useful, I'd be open to expanding what data is stored/displayed on the site. (e.g. Age, Trained at etc.) |
Hi, Here's a sample of the json copy pasted:
|
Hi @Gvanderl Happy to change the format up, but it will require some changes to the site (not too big of an issue). An object of units does make more sense than an array of units. Key-wise, slugifying the names would probably be cleaner, (e.g. I do like that this dataset has both I assume things like the image url, category (infantry, calvary, naval etc.), sub category ("line", militia, spearmen, camel, knight, etc.) and civ (if unit is unique to) can be easily included as they are displayed on the wiki page we're scraping from. "Trained at", "Resource cost" and "Age" might be nice additions too. I did some digging around and managed to find the original endpoint I stumbled across. It looks like it has since been updated. Our current dataset includes 63 units, whereas the live api link includes 100. Still no inclusion of the |
Hi !
Love your tool, however, certain units (like the obuch) are missing counters and others (like the Charkram thrower) are missing entirely. I was wondering if it would be possible to use web scraping to extract all the units and their counters from the aoe2 wiki directly, to ensure it's always up to date.
I could even write the web scraper in python if you think this'd be a good idea.
The text was updated successfully, but these errors were encountered: