Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for vertex colors #3

Open
trusktr opened this issue Jan 14, 2023 · 0 comments · May be fixed by #12
Open

add support for vertex colors #3

trusktr opened this issue Jan 14, 2023 · 0 comments · May be fixed by #12

Comments

@trusktr
Copy link
Member

trusktr commented Jan 14, 2023

we already have the vColor variable in the shader here,

three-meshline/src/THREE.MeshLine.js

Line 360 in b4a5ebd

varying vec4 vColor;

we just need to support setting it from a color vertex attribute. Align the API with vertexColors that three.js materials have.
@trusktr trusktr linked a pull request Nov 4, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add vertex color support ImUrX/three-meshline
1 participant
@trusktr