Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign of message decoders #196

Open
lare96 opened this issue Jan 5, 2020 · 0 comments
Open

Redesign of message decoders #196

lare96 opened this issue Jan 5, 2020 · 0 comments
Assignees
@lare96
Labels
average An issue that is neither hard nor easy to resolve. medium priority An issue that can be resolved whenever, but is guaranteed to be completed.
Milestone
v0.5

Comments

@lare96
Copy link
Member

lare96 commented Jan 5, 2020

They should be able to define an event type to decode, and have the option to handle it additionally once the event object has been created.

The drop, equip, etc. decoders should be renamed to something different, as they don't just serve solely that purpose. I'm currently unaware of the specific trigger that makes the client send a different packet for the same context slot. Will have to take a look at the client to find out
@lare96 lare96 self-assigned this Jan 5, 2020
@lare96 lare96 added medium priority An issue that can be resolved whenever, but is guaranteed to be completed. average An issue that is neither hard nor easy to resolve. labels Jan 5, 2020
@lare96 lare96 added this to the v0.5 milestone Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lare96 lare96

Labels
average An issue that is neither hard nor easy to resolve. medium priority An issue that can be resolved whenever, but is guaranteed to be completed.
Projects
None yet
Milestone
v0.5
Development

No branches or pull requests
1 participant
@lare96