Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependencies #99

Open
Holo-Viktor opened this issue Sep 16, 2019 · 1 comment
Open

Circular dependencies #99

Holo-Viktor opened this issue Sep 16, 2019 · 1 comment

Comments

@Holo-Viktor
Copy link

according to the readmes ABICC requires ABI dumper and ABI dumper requires ABICC

@Dave-Allured
Copy link

It looks like there is a simple mistake in the documentation for abi-dumper, and there is no actual circular dependency.

abi-dumper/README.md says this:

Requires
...
ABI Compliance Checker >= 2.2 (https://github.com/lvc/abi-compliance-checker)

However, no such dependency is listed in abi-dumper/INSTALL.

I did not check the code in detail, but this makes sense in this code architecture. If developer agrees, would you please remove this dependency line for ABI Compliance Checker in abi-dumper/README.md. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants