Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated np.float with np.float32 #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

assafbot
Copy link

np.float was deprecated in numpy 1.20

@assafbot
Copy link
Author

this PR fixes this bug #37

@rbgirshick
Copy link
Collaborator

The deprecation warning states:

DeprecationWarning: np.float is a deprecated alias for the builtin float. To silence this warning, use float by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use np.float64 here.

I'd prefer the fix to follow the message and use builtin float rather than np.float32

@thanhmvu
Copy link

I also got AttributeError: module 'numpy' has no attribute 'float' with np.float. Switching to float fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants