Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install leaves support files to current directory #9

Open
ivuorinen opened this issue Sep 4, 2024 · 0 comments
Open

Install leaves support files to current directory #9

ivuorinen opened this issue Sep 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ivuorinen
Copy link

Describe the bug

The install script should run git clone to a temporary directory that gets cleaned after install process. Now the install process leaves repo files to the directory where the installation was performed.

Noticed this after installing and the following files were caught in my $HOME/.dotfiles/scripts/ folder. Here's the git status:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        .github/
        README.md
        img/
        lib/
        set-env.fish
        set-env.zsh

Steps to reproduce

Add this plugin and run install.

Expected behavior

The install process shouldn't leave any repo related support files after installation.

Additional context

Please see these other plugins install scripts for inspiration:

@ivuorinen ivuorinen added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant